Assessment reportsPublic findings
Back to Zellic siteBack
↗
Assessment reports>Orderly Network>Threat Model>setMarketManager
GeneralOverview
Findings
Critical (1)
High (3)
Medium (4)
Informational (1)
DiscussionAdditional checksOverall issues with some functionsThe `changeFeeCollector` does not revertThe `tokenHash` is not a hash from `tokenAddress`
Threat ModelWhat are threat models?AccountTypeHelper.solAccountTypePositionHelper.solCrossChainRelayUpgradeable.solFeeManager.sol
Ledger.solaccountDepositaccountWithDrawFinishexecuteAdlexecuteLiquidationexecuteProcessValidatedFuturesexecuteSettlementexecuteWithdrawActionsetCrossChainManagersetFeeManagersetMarketManagersetOperatorManagerAddresssetVaultManager
LedgerComponent.solLedgerCrossChainManagerUpgradeable.solMarketManager.solOperatorManager.solOperatorManagerComponent.solSignature.solVault.solVaultCrossChainManagerUpgradeable.solVaultManager.sol
Audit ResultsSummary

Function: setMarketManager(address _marketManagerAddress)

This allows the owner of the contract to set the address of the marketManager contract.

Inputs

  • _marketManagerAddress

    • Control: onlyOwner of contract can call this function.

    • Constraints: The new address is not zero.

    • Impact: The setLastFundingUpdated timestamp will be updated in the MarketManager contract during the executeProcessValidatedFutures call.

Branches and code coverage

Intended branches

  • New address was set successfully.

Negative behavior

  • Zero address.

  • The same address already set.

  • Caller is not an owner.

Zellic © 2025Back to top ↑