Assessment reportsPublic findings
Back to Zellic siteBack
↗
Assessment reports>Orderly Network>Threat Model>setCrossChainManager
GeneralOverview
Findings
Critical (1)
High (3)
Medium (4)
Informational (1)
DiscussionAdditional checksOverall issues with some functionsThe `changeFeeCollector` does not revertThe `tokenHash` is not a hash from `tokenAddress`
Threat ModelWhat are threat models?AccountTypeHelper.solAccountTypePositionHelper.solCrossChainRelayUpgradeable.solFeeManager.sol
Ledger.solaccountDepositaccountWithDrawFinishexecuteAdlexecuteLiquidationexecuteProcessValidatedFuturesexecuteSettlementexecuteWithdrawActionsetCrossChainManagersetFeeManagersetMarketManagersetOperatorManagerAddresssetVaultManager
LedgerComponent.solLedgerCrossChainManagerUpgradeable.solMarketManager.solOperatorManager.solOperatorManagerComponent.solSignature.solVault.solVaultCrossChainManagerUpgradeable.solVaultManager.sol
Audit ResultsSummary

Function: setCrossChainManager(address _crossChainManagerAddress)

This allows owner of the contract to set the address of the crossChainManager contract.

Inputs

  • _crossChainManagerAddress

    • Control: onlyOwner of contract can call this function.

    • Constraints: The new address is not zero.

    • Impact: The crossChainManager contract has access to accountDeposit and accountWithDrawFinish functions. This allows to record the receipt of funds in another chain and complete the withdrawal process.

Branches and code coverage

Intended branches

  • New address was set successfully.

Negative behavior

  • Zero address.

  • The same address already set.

  • Caller is not an owner.

Zellic © 2025Back to top ↑