Assessment reportsPublic findings
Back to Zellic site
↗
Assessment reports>Nukem Loans>Threat Model>_domainSeparatorV4
GeneralOverview
Findings
Critical (3)
High (3)
Medium (2)
Low (1)
DiscussionInitializer called in constructorBorrowing on behalf of the Market contractPotential storage-collision issueSaferERC20 additional checksEIP-712 implementationMarket setters should only be called onceUtilizing eth-brownie for testingCentralizationAMM oracle pricing
Threat ModelWhat are threat models?AbstractSwapper.solAuctions.solCollateral.solCredit.solDebt.sol
EIP712.sol_domainSeparatorV4
ERC20Base.solERC20Permit.solEnFi4626.solLendingStrategy.solMarket.solProxyManager.solRoles.solSaferERC20.solUniswapV2Swapper.sol
Audit ResultsSummary

Function: _domainSeparatorV4()

This should build the domain separator for the current chain.

Branches and code coverage (including function calls)

Intended branches

  • Return the cached domain separator if the block.chainId is the same as the cached chain ID and the cached address. This is the same as the current address. Otherwise, build the domain separator. This is currently not performed and allows for replaying the signatures in case of a fork.

Zellic © 2023Back to top ↑