Deployment failure could waste gas
The StakingAdmin contract contains the deployment of many contracts in certain functions such as setupGsStaking
. In the case of a failure late in the deployment stage, a lot of funds in the form of gas could be lost.
One alternative could be to split up the deployment function, such that if one contract deployment fails then all other deployments are not reverted.