Description

In several areas of the project, internal inconsistencies were noted, such as lack of checks that were present in other areas, or non-standard practices in general.

The respective areas are affected:

• FractalVaultV1: withdrawToLayerOne - No chainId Checks.

• Mintable.sol: mint - Transfer event should mint from address 0.

• DexLibrary.sol: convertRewardTokensToDepositTokens - lack of slippage checks mentioned.

Impact

These issues are minor, and do not pose a security hazard at present. More broadly however, this is a source of developer confusion and a general coding hazard. Internal inconsistencies may lead to future problems or bugs. Avoiding internal inconsistencies also makes it easier for developers to understand the code and helps any potential auditors more quickly and thoroughly assess it.

Recommendations

Consider changing the code to fix the inconsistencies.

Remediation

The issue has been acknowledged by Fractal.