Assessment reports>Fractal Protocol>Discussion>Notable observations

Notable observations

In this section, we discuss miscellaneous interesting observations during the audit that are noteworthy and merit some consideration.

We applaud Fractal's initiative for taking on the challenge of yield farming over fragmented liquidity in multiple chains.

The quality of code is commendable, and the test coverage reaches almost 100% (99.6%).

Another point to consider may be that many functions such as mint which are allowed to be called by whitelisted addresses dictated by the owner pose a large centralization risk. This is by design but we would still suggest the following:

  • Use a multi-signature address wallet, this would prevent an attacker from causing irreversible damage if the EOA wallet were compromised.

  • Place dangerous functions like whitelists behind a timelock to catch malicious executions in the case of compromise.

Zellic © 2024Back to top ↑