Assessment reportsPublic findings
Back to Zellic site
↗
Assessment reports>Chainflip Backend>Threat Model>Function: `set_pool_fees`
GeneralOverview
Findings
Critical (1)
High (1)
Medium (1)
DiscussionLack of broker fee limitsERC-20 transfer reversions result in stuck fundsType conversion could lead to fund loss
Threat ModelWhat are threat models?1-cf-lp
2-cf-poolsPallet: cf-poolsFunction: `update_buy_interval`Function: `update_pool_enabled`Function: `new_pool`Function: `update_range_order`Function: `set_range_order`Function: `update_limit_order`Function: `set_limit_order`Function: `set_pool_fees`Function: `on_initialize`
3-cf-swapping4-cf-witnesser5-engine
Audit ResultsSummary

Function: set_pool_fees

The set_pool_fees function can be used by governance to set the percentage taken as fee.

The function ensures that the origin of the call is governance, validates the provided fee to ensure it is capped to a maximum amount, and updates the pool state to set the new fee. Updating fees requires collecting current fees before updating the fee parameter. Collected fees are credited to the liquidity providers. Finally, the function deposits an event to signal the update to the pool state.

Zellic © 2024Back to top ↑