Assessment reports>Chainflip Backend>Discussion>Lack of broker fee limits

Lack of broker fee limits

Note that in the audit version, there are no constraints on the broker fee limit other than that it is <= 100% (enforced by Permill):

let fee = Permill::from_parts(broker_commission_bps as u32 * BASIS_POINTS_PER_MILLION) *
    amount;

We do not consider this to be a security issue because users choose their brokers.

Zellic © 2024Back to top ↑