Assessment reportsPublic findings
Back to Zellic site
↗
Assessment reports>Chainflip Backend>Threat Model>Function: `set_limit_order`
GeneralOverview
Findings
Critical (1)
High (1)
Medium (1)
DiscussionLack of broker fee limitsERC-20 transfer reversions result in stuck fundsType conversion could lead to fund loss
Threat ModelWhat are threat models?1-cf-lp
2-cf-poolsPallet: cf-poolsFunction: `update_buy_interval`Function: `update_pool_enabled`Function: `new_pool`Function: `update_range_order`Function: `set_range_order`Function: `update_limit_order`Function: `set_limit_order`Function: `set_pool_fees`Function: `on_initialize`
3-cf-swapping4-cf-witnesser5-engine
Audit ResultsSummary

Function: set_limit_order

The set_limit_order function can be used to create or update an existing limit order. Similarly to update_limit_order, the function takes an order ID and a liquidity size; if the order ID corresponds to an existing order, the existing order is updated. Otherwise, a new order is created. Instead of receiving an increase or decrease, set_limit_order takes a specific amount to which the order liquidity should be changed to.

The function ensures that safe mode is not enabled and that the caller is a registered liquidity provider. If an existing order ID and a new tick range were provided, it moves the existing order to the new price level.

It then sets the order liquidity to the given amount. The amount can be specified in terms of an amount of assets or in terms of liquidity.

The user balance is updated every time their position is changed, ensuring the balance is always consistent with the position.

Zellic © 2024Back to top ↑