Assessment reportsPublic findings
Back to Zellic siteBack
↗
Assessment reports>Benqi Oracle>Threat Model>transferOracleAdmins
GeneralOverview
Findings
Medium (1)
Low (1)
DiscussionThe transferOracleAdmins function could always be revertedThe internal function BenqiPriceOracle::getFeedPrice is not usedIncorrect revert error message
Threat ModelWhat are threat models?
BenqiDualOracle.solcalculateDeviationgetFeedPricegetOraclePriceWithFreshnessgetUnderlyingPriceisPriceStalenormalizePricesetAssetOraclessetDeviationThresholdsetDirectPricesetMaxDeviationThresholdsetOracleModesetUnderlyingPricetransferOracleAdminsvalidateFeedPriceDeviation
BenqiPriceOracle.sol
Audit ResultsAssessment Results

Function: transferOracleAdmins(address newAdmin)

This function transfers the admin rights of both oracle contracts to a new address.

Inputs

  • newAdmin

    • Control: Fully controlled by the caller.

    • Constraints: None.

    • Impact: A new admin to transfer the admin rights to.

Branches and code coverage

Intended branches

  • Transfer the admin rights of the Edge oracle to the new admin.

  • Transfer the admin rights of the Chainlink oracle to the new admin.

Negative behavior

  • Revert if the caller is not an owner.

  • Revert if the new admin is a zero address.

Zellic © 2025Back to top ↑