Assessment reportsPublic findings
Back to Zellic siteBack
↗
Assessment reports>Benqi Oracle>Threat Model>setMaxDeviationThreshold
GeneralOverview
Findings
Medium (1)
Low (1)
DiscussionThe transferOracleAdmins function could always be revertedThe internal function BenqiPriceOracle::getFeedPrice is not usedIncorrect revert error message
Threat ModelWhat are threat models?
BenqiDualOracle.solcalculateDeviationgetFeedPricegetOraclePriceWithFreshnessgetUnderlyingPriceisPriceStalenormalizePricesetAssetOraclessetDeviationThresholdsetDirectPricesetMaxDeviationThresholdsetOracleModesetUnderlyingPricetransferOracleAdminsvalidateFeedPriceDeviation
BenqiPriceOracle.sol
Audit ResultsAssessment Results

Function: setMaxDeviationThreshold(uint256 newMaxThreshold)

This function sets the maximum-allowed deviation threshold.

Inputs

  • newMaxThreshold

    • Control: Fully controlled by the caller.

    • Constraints: None.

    • Impact: A new maximum deviation threshold to set the maximum deviation threshold of.

Branches and code coverage

Intended branches

  • Set the maximum deviation threshold.

Negative behavior

  • Revert if the caller is not an owner.

  • Revert if the new maximum deviation threshold is zero.

  • Revert if the new maximum deviation threshold is greater than 50e16.

Zellic © 2025Back to top ↑