Assessment reportsPublic findings
Back to Zellic siteBack
↗
Assessment reports>Benqi Oracle>Threat Model>isPriceStale
GeneralOverview
Findings
Medium (1)
Low (1)
DiscussionThe transferOracleAdmins function could always be revertedThe internal function BenqiPriceOracle::getFeedPrice is not usedIncorrect revert error message
Threat ModelWhat are threat models?
BenqiDualOracle.solcalculateDeviationgetFeedPricegetOraclePriceWithFreshnessgetUnderlyingPriceisPriceStalenormalizePricesetAssetOraclessetDeviationThresholdsetDirectPricesetMaxDeviationThresholdsetOracleModesetUnderlyingPricetransferOracleAdminsvalidateFeedPriceDeviation
BenqiPriceOracle.sol
Audit ResultsAssessment Results

Function: isPriceStale(uint256 timestamp, uint256 stalenessThreshold)

This function checks if a price is stale based on time stamp.

Inputs

  • timestamp

    • Control: Fully controlled by the caller.

    • Constraints: None.

    • Impact: A time stamp to check if the price is stale.

  • stalenessThreshold

    • Control: Fully controlled by the caller.

    • Constraints: None.

    • Impact: A staleness threshold to check if the price is stale.

Branches and code coverage

Intended branches

  • Check if the price is stale.

Zellic © 2025Back to top ↑