Assessment reports>Voyage>Discussion>Slither

Slither

Slither returns multiple warnings. Most warnings are already reported separately or false positives. However, we recommend fixing the following:

  • strictly following the checks-effects-interactions pattern

  • LoanFacet.liquidate(address,address,uint256) (contracts/voyage/facets/LoanFacet.sol#360-524) ignores return value by IERC20(param.currency).transfer(param.vault,refundAmount) (contracts/voyage/facets/LoanFacet.sol#460)

Zellic © 2024Back to top ↑