Assessment reportsPublic findings
Back to Zellic site
↗
Assessment reports>Perennial>Discussion>Incorrect documentation in Vault `Mapping`
GeneralOverview
Findings
Critical (1)
High (1)
Medium (1)
Low (2)
DiscussionUnnecessary storage assignments in `MappingStorageLib` waste gasIncorrect documentation in Vault `Mapping`Market user interface may be misleadingMissing fee claim mechanismUndercollateralized positions possible
Threat ModelWhat are threat models?Market.solMarketFactory.solMultiInvoker.solOracle.solOracleFactory.solVault.solVaultFactory.sol
Audit ResultsSummary
AppendixVault inflation POC codeNegative Liquidation PoC codeMultiInvoker drain POC code

Incorrect documentation in Vault Mapping

In Mapping in Vault, for ready(), the comment erroneously says "The latest mapping is ready to be settled when all ids in this mapping are greater than the latest mapping" when it should be that it's ready to be settled when all ids are less than or equal to the latest mapping.

Zellic © 2023Back to top ↑