Assessment reportsPublic findings
Back to Zellic site
↗
Assessment reports>Orderly Network>Threat Model>setMaxWithdrawFee
GeneralOverview
Findings
Critical (1)
High (4)
Medium (3)
Informational (1)
DiscussionAdditional checksOverall issues with some functionsThe `changeFeeCollector` does not revertThe `tokenHash` is not a hash from `tokenAddress`
Threat ModelWhat are threat models?AccountTypeHelper.solAccountTypePositionHelper.solCrossChainRelayUpgradeable.solFeeManager.solLedger.solLedgerComponent.solLedgerCrossChainManagerUpgradeable.solMarketManager.solOperatorManager.solOperatorManagerComponent.solSignature.solVault.solVaultCrossChainManagerUpgradeable.sol
VaultManager.soladdBalancefinishFrozenBalancefrozenBalancesetAllowedBrokersetAllowedChainTokensetAllowedSymbolsetAllowedTokensetMaxWithdrawFeesubBalance
Audit ResultsSummary

Function: setMaxWithdrawFee(byte[32] _tokenHash, uint128 _maxWithdrawFee)

This allows the owner of the contract set the max value of the withdraw fee for token.

Inputs

  • _tokenHash

    • Control: Full control by owner.

    • Constraints: N/A.

    • Impact: N/A.

  • _maxWithdrawFee

    • Control: Full control by owner.

    • Constraints: N/A.

    • Impact: This value is used in the executeWithdrawAction function to check that the fee is not exceeding the allowed value.

Branches and code coverage

Negative behavior

  • Caller is not an owner.

  • Zero hash.

Zellic © 2024Back to top ↑