Assessment reportsPublic findings
Back to Zellic site
↗
Assessment reports>Lido Fixed Income>Threat Model>createVault
GeneralOverview
Findings
Critical (2)
High (3)
Medium (2)
Low (5)
Informational (2)
DiscussionConsider transferring stETH instead of ETHConfusing math in finalizeVaultEndedWithdrawalsPremium claim requirement ensures safety tooComment implies more centralization than existsUse batch withdrawals for gas savingsUnused event `VaultCodeSet`
Threat ModelWhat are threat models?LidoVault.sol
VaultFactory.solcreateVault
Audit ResultsSummary

Function: createVault(uint256 _fixedSideCapacity, uint256 _duration, uint256 _variableSideCapacity)

This function is to create a new LidoVault with initialize value.

Inputs

  • _fixedSideCapacity

    • Control: Arbitrary.

    • Constraints: None.

    • Impact: The value of fixed-side capacity.

  • _duration

    • Control: Arbitrary.

    • Constraints: None.

    • Impact: The value of staking duration.

  • _variableSideCapacity

    • Control: Arbitrary.

    • Constraints: None.

    • Impact: The value of variable-side capacity.

Branches and code coverage

Intended branches

  • Create vault with initialized params.

Negative behavior

  • Reverts if the vaultAddress is zero.

Zellic © 2024Back to top ↑