Assessment reports>Lido Fixed Income>Discussion>Comment implies more centralization than exists

Comment implies more centralization than exists

In the preamble to the isEnded() view function, there is a notice:

/// @notice True if the vault has ended
/// or the admin has settled all debts thus effectively ending the vault
function isEnded() public view returns (bool) {
  return (endTime > 0 && block.timestamp > endTime);
}

However, this likely refers to an older version of the contract as there is no admin. The current version is less centralized, so removing this comment would reduce alarm from casual readers of the contract source.

This issue has been acknowledged by Saffron, and a fix was implemented in commit 32b5db84.

Zellic © 2024Back to top ↑