Assessment reportsPublic findings
Back to Zellic site
↗
Assessment reports>Initia>Low findings>Hex decode accepting invalid characters
GeneralOverview
Findings
Critical (3)
High (12)
Medium (4)
Low (9)Ability to bypass swap feesModule can be duplicated in module publish requestsHex decode accepting invalid charactersBad decimal-parsing function accepts multiple dotsPotential out-of-gas reversion when checking object permissionsIncorrect string-formatting helperIncorrect minimum-TVL module-parameter checkError not checked when fetching starting infoMove coins are case-insensitive in cosmos
Informational (3)
DiscussionGeneral DiscussionImprove AMM testsBridge executor minting powerCharge before using valuesEmpty allowed_publishers array allows every address to publishERC20Keeper with custom contractsSuggestions for additional security checksTable handle overflow leads to abort
Threat ModelWhat are threat models?stdlib
Audit ResultsSummary
AppendixProof of concept: Reference safety verifier bypass
Category: Coding Mistakes

Hex decode accepting invalid characters

Low Severity
Low Impact
Low Likelihood

Description

The hex.move module provides helper functions that can be used to convert a bytes array to and from a hexadecimal representation.

The decode_string accepts characters that are not valid hexadecimals and decodes characters that are not in the range 0-9a-f. This causes the strings 1f and 0g to be decoded to the value 0x1f.

Impact

This issue is reported as low impact since we could not identify an exploitation path using only the in-scope code. However, the impact could be higher for third-party modules.

Recommendations

Validate the input to ensure it contains only valid hexadecimal characters.

Remediation

Zellic © 2024Back to top ↑