Description

The FeeHelpers::handle_sell_asset and FeeHelpers::handle_buy_asset functions are not handling a potential error that may be returned by invocations of OFLA::unlock_fee.

Impact

The unlock_fee function could potentially fail and return an error; however, this does not seem possible to occur in practice, and as such, this finding is reported as Informational.

Recommendations

We recommend handling errors explicitly for all functions that could potentially return an error. If expected to never fail, it can be acceptable to handle errors via assertions.

Remediation

This informational finding constitutes a violation of error handling best practices but is not an exploitable issue. Gasp believes this function will never return an error, and therefore opted not to make changes to the codebase in response to this finding.