Category: Coding Mistakes
Missing handling-of-transaction revert
Informational Impact
Informational Severity
Low Likelihood
Description
The SendNewOpTask and SendNewRdTask functions, part of the aggregator-service implementation (in avs_writer.go) do not check whether a transaction was successfully executed.
The functions assume the first entry of receipt.Logs exists, but this is not technically guaranteed, as the transaction could potentially revert and have no logs.
Impact
This issue appears to be unlikely to manifest in practice. However, if the transaction submitted by SendNewOpTask or SendNewRdTask were to revert, it would cause the aggregator to panic and crash.
Recommendations
Handle potential reverts in SendNewOpTask and SendNewRdTask.
Remediation
This issue has been acknowledged by Gasp, and a fix was implemented in commit eca9fa7f↗.