Category: Business Logic
Lack of storage gap in the contract EIP712VerifierU
Low Severity
Low Impact
Low Likelihood
Description
When using upgradable contracts, storage gaps are used for reserving storage slots in a base contract, allowing upgrade of that contract to use up those slots without affecting the storage layout. However, the upgradable contract EIP712VerifierU does not have a storage-gap variable, and it is inherited by other contracts.
Impact
If new storage variables are added to the contract EIP712VerifierU in the future, it will affect the storage variables in the child contract.
Recommendations
Consider adding a gap variable to be safe against storage collisions.
Remediation
This issue has been acknowledged by RabbitX, and a fix was implemented in commit a7fa5c60↗.