Assessment reports>Ethereum and Blast Exchanges>Informational findings>Incorrect event-parameter order
Category: Coding Mistakes

Incorrect event-parameter order

Informational Severity
Informational Impact
N/A Likelihood

Description

In the contract BfxDepositU, the parameters passed to the event Deposit are in a different order than the order defined in the interface IPoolDeposit2. The last two parameters of the event are defined as token and poolId, but BfxDepositU passes them as poolId and token.

event Deposit(
    string id,
    address indexed trader,
    uint256 amount,
    address indexed token,
    uint256 indexed poolId
);
function individualDeposit(address contributor, uint256 amount) external {
    // [...]
    emit Deposit(depositId, contributor, amount, 0, defaultToken);
    // [...]
}

Impact

This will cause the contract BfxDepositU to fail to compile.

Recommendations

Consider modifying the parameter order to match the definition.

Remediation

This issue has been acknowledged by RabbitX, and a fix was implemented in commit a7fa5c60.

Zellic © 2025Back to top ↑