Assessment reportsPublic findings
Back to Zellic site
↗
Assessment reports>Cega>Threat Models>Function: removeOptionBarrier(address vaultAddress, uint256 index, string _asset)
GeneralOverview
Findings
High (1)
Medium (4)
Low (2)
Informational (2)
DiscussionCentralization risksUsing non-ERC20 token standardsImpossibility of reentrancy in the queue-processing functions
Threat ModelsWhat are threat models?CegaState.sol
FCNProduct.solFunction: addOptionBarrier(address vaultAddress, OptionBarrier optionBarrier)Function: addToDepositQueue(uint256 amount, address receiver)Function: addToWithdrawalQueue(address vaultAddress, uint256 amountShares, address receiver)Function: calculateCurrentYield(address vaultAddress)Function: calculateVaultFinalPayoff(address vaultAddress)Function: checkBarriers(address vaultAddress)Function: createVault(string _tokenName, string _tokenSymbol, uint256 _vaultStart)Function: openVaultDeposits(address vaultAddress)Function: processDepositQueue(address vaultAddress, uint256 maxProcessCount)Function: processWithdrawalQueue(address vaultAddress, uint256 maxProcessCount)Function: receiveAssetsFromCegaState(address vaultAddress, uint256 amount)Function: removeOptionBarrier(address vaultAddress, uint256 index, string _asset)Function: removeVault(address vaultAddress)Function: rolloverVault(address vaultAddress)Function: setIsDepositQueueOpen(bool _isDepositQueueOpen)Function: setKnockInStatus(address vaultAddress, bool newState)Function: setManagementFeeBps(uint256 _managementFeeBps)Function: setMaxDepositAmountLimit(uint256 _maxDepositAmountLimit)Function: setTradeData(address vaultAddress, uint256 _tradeDate, uint256 _tradeExpiry, uint256 _aprBps, uint256 _tenorInDays)Function: setVaultMetadata(address vaultAddress, FCNVaultMetadata metadata)Function: setVaultStatus(address vaultAddress, VaultStatus _vaultStatus)Function: setYieldFeeBps(uint256 _yieldFeeBps)Function: updateOptionBarrierOracle(address vaultAddress, uint256 index, string _asset, string newOracleName)
Oracle.sol

Function: removeOptionBarrier(address vaultAddress, uint256 index, string _asset)

Removes an option barrier from a vault metadata's optionBarriers array and shifts all other elements down.

Inputs

  • vaultAddress

    • Control: Fully controlled.

    • Constraints: N/A.

    • Impact: This vault's metadata is accessed and updated.

  • index

    • Control: Fully controlled.

    • Constraints: Used to index into the vault metadata's optionBarriers array.

    • Impact: N/A.

  • _asset

    • Control: Fully controlled.

    • Constraints: Must match the asset of the option barrier being removed.

    • Impact: N/A.

Branches and code coverage (including function calls)

Intended branches

  • Should remove the indexed option barrier and shift all other option barriers down.

Negative behaviour

  • Should revert if called by a non--trader-admin role.

  • Should revert if the index argument is out of bounds of the vault metadata's optionBarriers array.

  • Should revert if the _asset argument does not match the asset stored in the indexed option barrier.

Zellic © 2024Back to top ↑