Category: Coding Mistakes
The collateralizedMint function lacks the nonReentrant modifier
Informational Impact
Informational Severity
N/A Likelihood
Description
The collateralizedMint function lacks the nonReentrant modifier, which would prevent a reentrancy attack in the function.
Impact
Since the collateralizedMint function does an external call of the onERC1155Received function of the shares receiver contract, it can theoretically be reentered in, with apparently no security implications as for the current state of the contract.
Recommendations
We recommend adding the nonReentrant modifier to the collateralizedMint function.
Remediation
This issue has been acknowledged by Alkimiya, and fixes were implemented in the following commits: