Assessment reportsPublic findings
Back to Zellic site
↗
Assessment reports>WOOFi Swap>Threat Model>sgReceive
GeneralOverview
Findings
High (2)
Medium (3)
Low (2)
Informational (2)
DiscussionFunction `skimMulTokens` does not workThrowing Panic is not recommendedThe WooPPV2 contract doesn't need to be an admin
Threat ModelWhat are threat models?
WooCrossChainRouterV4.sol_bridgeByStargate_handleERC20Received_handleNativeReceivedclaimFeecrossSwapinCaseTokenGotStuckpausesgReceiveunpause
WooPPV2.solWooRouterV2.sol
Audit ResultsSummary

Function: sgReceive(uint16, bytes, uint256, address bridgedToken, uint256 amountLD, bytes payload)

Function that handles receiving via StarGate.

Inputs

  • srcChainId

    • Control: Fully controlled by the caller. Currently not used.

    • Constraints: None. Should check that it is a valid chain ID for the source chain.

    • Impact: The source chain where the cross-chain transaction originated.

  • srcAddress

    • Control: Fully controlled by the caller. Currently not used.

    • Constraints: None. Should check that it corresponds to the WoocrossChainRouterV4 contract on the source chain.

    • Impact: The address of the originating contract on the source chain.

  • nonce

    • Control: Fully controlled by the caller. Currently not used.

    • Constraints: None. Should be used to prevent replay attacks.

    • Impact: The nonce of the transaction.

  • bridgedToken

    • Control: Fully controlled by the caller.

    • Constraints: None. Assumed to be a token that can be bridged.

    • Impact: The token that was bridged.

  • amountLD

    • Control: Fully controlled by the caller.

    • Constraints: None. Assumed to be the amount of the bridged token. When called by StarGate, StarGate ensures that this amount the token has been transferred to the contract by StarGate as a result of the cross-chain call.

    • Impact: The amount of the bridged token.

  • payload

    • Control: Fully controlled by the caller.

    • Constraints: None. Assumed to be the payload of the cross-chain transaction.

    • Impact: The payload of the cross-chain transaction.

Branches and code coverage

Intended branches

  • Ensure that srcChainId is a valid chain ID. Currently not enforced.

  • Ensure that srcAddress corresponds to the WoocrossChainRouterV4 contract on the source chain. Currently not enforced.

  • Ensure that nonce is used to prevent replay attacks. Currently not enforced.

  • If bridgedToken is SGETH, handle the native received.

  • If bridgedToken is not SGETH, handle the ERC-20 received.

Negative behavior

  • Should not allow anyone other than the StarGate router to call this function.

Zellic © 2024Back to top ↑