Assessment reportsPublic findings
Back to Zellic site
↗
Assessment reports>WOOFI Stake>Threat Model>upgradeStrat
GeneralOverview
Findings
Critical (1)
Medium (2)
Low (1)
DiscussionInstant withdraw cap can be bypassedSimilarities to ERC-4626 first-deposit issueSlippage check not performed during compoundReward function
Threat ModelWhat are threat models?BaseStrategy.solStrategyAave.sol
VaultV2.soldepositearninCaseNativeTokensGetStuckinCaseTokensGetStuckproposeStratupgradeStratwithdraw
WooLendingManager.solWooStakingCompounder.solWooStakingController.solWooStakingLocal.solWooStakingManager.solWooStakingProxy.solWooSuperChargerVaultV2.solWooWithdrawManagerV2.sol
Audit ResultsAssessment Results

Function: upgradeStrat()

This function facilitates the upgrade of a strategy.

Branches and code coverage

Intended branches

  • Assumed that the current strategy has no more funds or rewards to claim. Currently not explicitly checked.

  • Check whether the current implementation is set.

  • Check if the proposed time has passed.

  • Retire the current strategy.

  • Update the strategy to the new implementation.

  • Deposit funds into the new strategy. Performed in earn.

Negative behavior

  • Should not be callable by anyone other than the admin.

Zellic © 2024Back to top ↑