Category: Coding Mistakes
Unused functionality should be removed
Informational Severity
Informational Impact
N/A Likelihood
Description
The TokenController
contract is a base contract that assists child contracts in matching local to remote token addresses. This contract adds complexity, however, important functions are not used elsewhere. Specifically linkTokenPair()
and unlinkTokenPair()
intended for matching local tokens to remote tokens present functionality that is not consumed.
Impact
Informational issue, some functionality is adding unnecessary complexity.
Recommendations
We recommend removal of unnecessary functions, and simplification of contract inheritance where possible.
Remediation
This issue has been acknowledged by Trillion, and a fix was implemented in commit 75db8873↗.