Assessment reports>Scroll zkEVM>Discussion>Mistakes in the example table in the EVM circuit documentation

Mistakes in the example table in the EVM circuit documentation

The file docs/EVM_Circuit.md documents the functioning of the EVM circuit. Under the section "Circuit Layout", an example table is provided. There are some differences between this table and the code.

In the table, q_step_first is enabled for all rows of the first step, but in the code it is only enabled on the first row of the first step, analogously for q_step_last. For num_rows_until_next_step, the table shows this being zero in the last row of a step and then counting down until the next zero. However, in the code, it is zero in the first row of each step. Thus, the column should be 0, 5, 4, 3, 2, 1, 0, 6, 5, ... instead of 5, 4, 3, 2, 1, 0, 6, 5, ....

The q_step_first and q_step_last columns were fixed in commit .

Zellic © 2024Back to top ↑