Assessment reports>Pyth2Wormhole>Discussion>Extraneous test condition in terra test code

Extraneous test condition in terra test code

The test_verify_vaa_sender_fail_wrong_emitter_address test in the terra codebase is meant to only test that verify_vaa_sender fails if the emitter_address is incorrect. This first tests the intended condition, but then tests that verify_vaa_sender fails if the emitter_chain is incorrect. This is a useful invariant to validate but is already exercised by a separate test test_verify_vaa_sender_fail_wrong_emitter_chain already and should be removed from test_verify_vaa_sender_fail_wrong_emitter_address.

Zellic © 2024Back to top ↑