Description

Some parts of the codebase use safeTransfer and safeTransferFrom, but there are sections that still use transferFrom as is.

function bid(uint256 buyReserveAmount, uint256 sellCouponAmount) external auctionActive returns(uint256) {
  //...

  IERC20(buyCouponToken).transferFrom(msg.sender, address(this), sellCouponAmount);
  // ...

Impact

There is no issue with the whitelist token intended for use, but using safe functions is recommended.

Recommendations

Use safeTransfer and safeTransferFrom for best practice.

Remediation

This issue has been acknowledged by Plaza Finance, and fixes were implemented in the following commits:

• 4fc6239b↗
• 76615d29↗