Assessment reports>Metavest>Threat Model>updateFunctionCondition

Function: updateFunctionCondition(address _condition, byte[4] _functionSig)

This function is used to add the condition contract for a function signature.

Inputs

  • _condition

    • Control: Arbitrary.

    • Constraints: None.

    • Impact: Address of the condition contract to be added to the functionToConditions mapping for the _functionSig.

  • _functionSig

    • Control: Arbitrary.

    • Constraints: None.

    • Impact: Signature of the function to update the functionToConditions mapping.

Branches and code coverage

Intended branches

  • Check that the condition contract does not revert.

  • Update the functionToConditions mapping.

Negative behavior

  • Revert if the caller is not the DAO.

Function call analysis

  • IConditionM(_condition).checkCondition(address(this), msg.sig, "")

    • What is controllable? N/A.

    • If the return value is controllable, how is it used and how can it go wrong? N/A.

    • What happens if it reverts, reenters or does other unusual control flow? N/A.

Zellic © 2024Back to top ↑