Assessment reports>Hyperlane Starknet>Informational findings>Unnecessary class function for signature conversion
Category: Code Maturity

Unnecessary class function for signature conversion

Informational Severity
Informational Impact
N/A Likelihood

Description

The convert_to_signature function is defined as a class function, but it does not interact with the contract state.

Impact

This issue does not pose a security risk but may lead to confusion or suboptimal code organization.

Recommendations

The convert_to_signature function can be defined as a free function outside the class structure. If kept within the class, adding self as a parameter makes it consistent with other class methods, though this is not strictly necessary for its functionality.

Remediation

This issue has been acknowledged by Pragma, and a fix was implemented in commit fcb0a419.

Zellic © 2025Back to top ↑