Function: clobDeposit(address token, uint256 amount, bool fromRouter)

This function allows depositing the specified amount of token to the CLOBManager contract.

Inputs

• token

  • Control: Full control.

  • Constraints: CLOBManager allows depositing arbitrary tokens.

  • Impact: The address of the token will be deposited to the CLOBManager contract.

• amount

  • Control: Full control.

  • Constraints: The caller should own enough tokens to transfer them to the CLOBManager contract.

  • Impact: The amount of token to be transferred to the CLOBManager contract.

• fromRouter

  • Control: Full control.

  • Constraints: N/A.

  • Impact: If fromRouter is true, then the tokens are transferred to this contract, and approval is granted to the CLOBManager contract to use these tokens. Otherwise, tokens will be transferred from the caller account.

Branches and code coverage

Intended branches

• Tokens are successfully deposited when fromRouter is true.

  Test coverage

• Tokens are successfully deposited when fromRouter is false.

  Test coverage

Negative behavior

• The amount exceeds the caller’s balance of the token.

  Negative test

Function call analysis

• SafeTransferLib.safeTransferFrom(token, msg.sender, address(this), amount)

  • What is controllable? token and amount.

  • If the return value is controllable, how is it used and how can it go wrong? There is no return value here.

  • What happens if it reverts, reenters or does other unusual control flow? There are no problems here.

• SafeTransferLib.safeApprove(token, address(this.clobFactory), amount)

  • What is controllable? token and amount.

  • If the return value is controllable, how is it used and how can it go wrong? There is no return value here.

  • What happens if it reverts, reenters or does other unusual control flow? There are no problems here.

• this.clobFactory.deposit(msg.sender, token, amount, fromRouter)

  • What is controllable? token, amount, and fromRouter.

  • If the return value is controllable, how is it used and how can it go wrong? There is no return value here.

  • What happens if it reverts, reenters or does other unusual control flow? There are no problems here.