Category: Coding Mistakes
Reward and withdrawal payout getters might fail if the etherFiNode version is not updated
Low Severity
Low Impact
Medium Likelihood
Description
If version of etherFiNode is zero, the functions EtherFiNodeManager.sol:getRewardsPayouts
and EtherFiNodeManager.sol:getFullWithdrawalPayouts
will revert. This is because the modifier ensureLatestVersion
ensures that the version of etherFiNode is nonzero.
Impact
The functions getRewardsPayouts
and getFullWithdrawalPayouts
will revert in certain cases.
Recommendations
We recommend removing ensureLatestVersion
for getRewardsPayouts
and getFullWithdrawalPayouts
functions.
Remediation
This issue has been acknowledged by EtherFi, and a fix was implemented in commit 405b37cc↗.