Description

In the process of validating the message, there is an assertion that always fails.

While the message length is always greater than 65 bytes, taking the modulo of the length by 32 will always result in a value less than 32, making it impossible to equal 65.

fun parse_deposit_payload(received_asset_metadata: Object<Metadata>, received_asset_amount: u64, message: vector<u8>): DepositPayload acquires DepositManagerController {
    // [...]
    assert!(vector::length(&message) % 32 == 65, ERR_DEPOSIT_MANAGER_MALFORMED_PAYLOAD);
    // [...]
}

Impact

Regardless of the validity of the message, parse_deposit_payload will always cause a revert.

Recommendations

Make a different assertion to properly validate the message.

Remediation

This issue has been acknowledged by Echelon, and a fix was implemented in commit c368b175↗.