Assessment reportsPublic findings
Back to Zellic site
↗
Assessment reports>Cove>Informational findings>Mismatch between CoW Swap adapter sequence diagram and implementation
GeneralOverview
Findings
Critical (2)
High (3)
Medium (2)
Low (1)
Informational (1)Mismatch between CoW Swap adapter sequence diagram and implementation
DiscussionTransparent intent of redeemal might lead to unintended consequencesShares can round down to zeroWeights can pass uncheckedDenial-of-service risk where attackers can disrupt rebalance process with BasketManagerUtils.completeRebalance() functionality
Threat ModelWhat are threat models?AnchoredOracle.solAssetRegistry.solBasketManagerUtils.solBasketToken.solCoWSwapAdapter.solCoWSwapClone.solFeeCollector.solManagedWeightStrategy.sol
Audit ResultsAssessment Results
Category: Code Maturity

Mismatch between CoW Swap adapter sequence diagram and implementation

Informational Severity
Informational Impact
N/A Likelihood

Description

The sequence diagram for the CoW Swap adapter pictured here↗ differs from the implementation. Quotes for token swaps should be retrieved before calling proposeTokenSwap(), and the loop should begin at proposeTokenSwap(), as completeRebalance resets the status to REBALANCE_PROPOSED.

Recommendations

Fix the sequence diagram to reflect the actual implementation flow.

Impact

The mismatch between the sequence diagram and the implementation may cause confusion for users.

Remediation

The documentation has been updated by Storm Labs to reflect the actual implementation flow.

Zellic © 2025Back to top ↑