Assessment reportsPublic findings
Back to Zellic siteBack
↗
Assessment reports>Benqi Oracle>Threat Model>setAdmin
GeneralOverview
Findings
Medium (1)
Low (1)
DiscussionThe transferOracleAdmins function could always be revertedThe internal function BenqiPriceOracle::getFeedPrice is not usedIncorrect revert error message
Threat ModelWhat are threat models?BenqiDualOracle.sol
BenqiPriceOracle.solassetPricesgetFeedgetFeedPricegetPriceAndTimestampgetUnderlyingPricegetUnderlyingPriceWithTimestampsetAdminsetDirectPricesetFeedsetUnderlyingPrice
Audit ResultsAssessment Results

Function: setAdmin(address newAdmin)

This function is used to set the admin of the contract.

Inputs

  • newAdmin

    • Control: Fully controlled by the caller.

    • Constraints: None.

    • Impact: A new admin to set the admin to.

Branches and code coverage

Intended branches

  • Set the admin of the contract.

Negative behavior

  • Revert if the caller is not a service admin.

Zellic © 2025Back to top ↑