Assessment reports>BEND v2>Discussion>Consider adding a parameter for the previous value in the FeePercentageSet event

Consider adding a parameter for the previous value in the FeePercentageSet event

In the MetaFeePartitioner contract, setDefaultPlatformFeePercentage emits the DefaultPlatformFeePercentageSet event, which includes the previous (old) value.

function setDefaultPlatformFeePercentage(uint256 newFee) external onlyOwner {
    // [...]
    emit EventsLib.DefaultPlatformFeePercentageSet(old, newFee);
}

However, setFeePercentage emits FeePercentageSet without the previous value.

function setFeePercentage(address vault, uint256 newFee) external onlyOwner {
    // [...]
    emit EventsLib.FeePercentageSet(vault, newFee);
}

We recommend adding a parameter for the previous value to the FeePercentageSet event for consistency and improved observability.

Zellic © 2025Back to top ↑