Category: Coding Mistakes
Tranche name hardcodes junior symbol
Informational Severity
Informational Impact
High Likelihood
Description
In the initializer for Tranche, the ERC-20 initializer is called with j
concatenated onto the name of the underlying asset:
__ERC20_init_unchained(
string(abi.encodePacked(trancheName,
abi.encodePacked(" Tranche ", ERC20(__asset).name()))),
string(abi.encodePacked("j", ERC20(__asset).symbol()))
);
However, this means that both the junior and senior tranches use j
and then the underlying asset symbol.
Impact
Holders of senior tranche tokens may be misled by the incorrect name.
Recommendations
Set the symbol depending on the name of the tranche.
Remediation
This issue has been acknowledged by Avantis Labs, Inc., and a fix was implemented in commit 9e9cfb73↗.