From the creators of the Revest Protocol, Revest Finance is proud to introduce Resonate. Resonate intends to solve one of the biggest problems in DeFi by creating a marketplace for swapping up-front interest payments for future yields. Resonate uses pools to group traders by product attributes (locking terms, asset type, etc.) and clears orders using an automated queue-based matching system. The protocol is built on top of Revest and uses much of the existing infrastructure, including lockable FNFTs.
Zellic conducted a second audit for Revest Finance from July 25th to July 27th, 2022.
This second audit covered the same code base as the audit performed from July 18th to July 22nd, 2022. This second audit included new contracts and some changes to contracts reviewed in the previous audit.
All findings presented here reflect only the new code. Please refer to the previous report for findings that still exist in this code base but that were present at the time of last review. All discussion points that still broadly apply remain.
Our general overview of the code is unchanged. It appears mechanically optimized and gas efficient, using queues to match issuers and purchasers.
We applaud Revest Finance for the documentation and the articles that detail in depth the inner workings of the Resonate project, explaining not only the mechanism but also the economic incentives of the market participants.
Zellic thoroughly reviewed the Resonate codebase to find protocol-breaking bugs and to find any technical issues outlined in the Methodology section (2.2) of this document.
Zellic met with the Revest Finance team to discuss their threat model. In our review we paid special attention to its pass through governance and reentrancy, oracle, and centralization risks.
Due to the complexity of the protocol, we worked through many possible exchanges between issuers and purchasers across different pool configurations.
During our assessment on the scoped Resonate contracts, we discovered three findings. Two of which were of low severity, the remaining was informational in nature.
Additionally, Zellic recorded its notes and observations from the audit for Revest Finance's benefit in the Discussion section (ref) at the end of the document. Notes that still apply to the code based from the previous audit have been left as is for local completeness.