Description

There is a possible overflow in this calculation:

let pending_reward = (staker_info.bond_amount * state.global_reward_index).checked_sub(staker_info.bond_amount * staker_info.reward_index)?;

Impact

Calculations could be inaccurate and result in a loss of rewards.

Recommendations

Adjust the calculation to the equivalent one below:

let pending_reward = staker_info.bond_amount * state.global_reward_index.checked_sub(staker_info.reward_index)?;

Remediation

This issue has been acknowledged by Dojoswap Labs, PTE, and a fix was implemented in commit ce55f60d↗.