Assessment reports>1inch Farming>Low findings>Some methods are not exposed by their interface
Category: Code Maturity

Some methods are not exposed by their interface

Low Severity
Informational Impact
N/A Likelihood

Description

The interfaces IFarm and IFarmingPool do not expose the following methods from their concrete implementation:

IFarm.sol

  • startFarming (Farm.sol)

IFarmingPool.sol

  • startFarming (FarmingPool.sol)

  • decimals (FarmingPool.sol)

The interfaces also do not expose the onlyOwner setDistributor function, but we assume this is part of the intended design.

Impact

Consumers of this interface will not be able to call the unexposed methods.

Recommendations

If this is not the intended design, add the methods to the interface declarations.

Remediation

The issue was fixed by 1inch in commit 29bf4aed.

Zellic © 2024Back to top ↑